Create system.users table. #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| // only (SELECT and GRANT). These must remain set for the root user. | ||
| allowedPrivileges := privilege.SELECT.Mask() | privilege.GRANT.Mask() | ||
| if IsSystemID(id) { | ||
| // System databases and tables has custom maximum allowed privileges. |
|
LGTM |
| if p == privilege.ALL { | ||
| // We need to reset privileges as Revoke(ALL) will clear | ||
| // all bits. | ||
| descriptor.Revoke(security.RootUser, privilege.List{p}) |
|
LGTM |
Work towards #2090. This creates a new system table storing username/hashed-password that is currently in the users config (removal will come next). The main part of this change is applying custom permissions based on the system table. descriptor and namespace are read-only, but users needs to be modified.
mberhault
force-pushed
the
marc/system.users_table
branch
from
2fb069f
to
010e11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2090.
This creates a new system table storing username/hashed-password
that is currently in the users config (removal will come next).
The main part of this change is applying custom permissions based
on the system table. descriptor and namespace are read-only,
but users needs to be modified.