Remove accounting config #2256
Merged
Remove accounting config #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work towards #2090 Remove accounting config/keys/endpoints/cli/etc... There is currently nothing in the accounting config, and no exact plans. When this emerges, we'll move it into the system database alongside other configs.
|
LGTM |
| @@ -83,8 +83,8 @@ func (p PrefixConfigMap) Less(i, j int) bool { | |||
| // | |||
| // These additional entries allow for simple lookups by prefix and | |||
| // provide a way to split a range by prefixes which affect it. This | |||
| // last is necessary for accounting and zone configs; ranges must not | |||
| // span accounting or zone config boundaries. | |||
| // last is necessary for zone configs; ranges must not | |||
There was a problem hiding this comment.
uh. yeah. same as it was before, refers to "split a range by prefixes which affect it"
There was a problem hiding this comment.
i don't get it; this last what?
There was a problem hiding this comment.
aka: "the latter"
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2090
Remove accounting config/keys/endpoints/cli/etc...
There is currently nothing in the accounting config, and no exact plans.
When this emerges, we'll move it into the system database alongside
other configs.