sql/driver: misc cleanup #2375
sql/driver: misc cleanup #2375
Conversation
| @@ -62,50 +115,3 @@ func (Request) Method() Method { | |||
| func (Request) CreateReply() Response { | |||
| return Response{} | |||
| } | |||
|
|
|||
| // GetParameters returns the Params slice as a `parameters`. | |||
There was a problem hiding this comment.
This code movement was part of Vivek's change. Unless there was some crucial urgency to doing this move, just wait until his change gets merged.
|
LGTM, though hold off on merging until Vivek's change goes in. A cleanup PR like this should never place additional burden on another person's PR (e.g. having to deal with a rebase and code movement). I would even go farther to say that it is mildly dangerous to move code as you've done with the |
- sql/driver/conn.go: variable renaming - sql/driver/conn.go: small refactoring - sql/driver/conn.go: avoid copying a slice - sql/driver/conn.go: Exec avoids conversion to rows - static interface implementation assertions - sql/driver.Value implements `driver.Valuer`
| const ( | ||
| // Endpoint is the URL path prefix which accepts incoming | ||
| // HTTP requests for the SQL API. | ||
| Endpoint = "/sql/" | ||
|
|
||
| timestampWithOffsetZoneFormat = "2006-01-02 15:04:05.999999999-07:00" |
There was a problem hiding this comment.
@vivekmenezes note I removed this - there was no test checking it, and AFAICT it's only used in (driver.Datum).String() which isn't used anywhere. I added a test in wire_test.go, PTAL.
|
LGTM |
|
Lgtm On Sun, Sep 6, 2015, 2:48 PM Peter Mattis notifications@github.com wrote:
|
driver.Valuer