sql: sensible error when column default dropped in transaction #26781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The COMMIT statement used to return error: got 0 values but expected 1 The column backfiller's updateExprs[] was not being initialized properly. A NULL default value reflects now in a proper initialization of the default value to tree.DNull. related to cockroachdb#26422 Release note: None
|
This change is |
|
Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 18, 2018
26781: sql: sensible error when column default dropped in transaction r=vivekmenezes a=vivekmenezes The COMMIT statement used to return error: got 0 values but expected 1 The column backfiller's updateExprs[] was not being initialized properly. A NULL default value reflects now in a proper initialization of the default value to tree.DNull. related to #26422 Release note: None Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COMMIT statement used to return
error: got 0 values but expected 1
The column backfiller's updateExprs[] was not being
initialized properly. A NULL default value reflects now in
a proper initialization of the default value to tree.DNull.
related to #26422
Release note: None