backport-2.0: sqlmigrations: simplify descriptor validation to get around #26422 #26857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…db#26422 This validation is fine because the function itself is only upgrading the format via the migration path and not changing any cross references. If in the future if we decide to use this descriptor upgrade function for something more complex we can reintroduce the use of Validate. related to cockroachdb#26422 Release note: None
|
This change is |
knz
approved these changes
Jun 20, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 20, 2018
26857: backport-2.0: sqlmigrations: simplify descriptor validation to get around #26422 r=vivekmenezes a=vivekmenezes Backport 1/1 commits from #26784. /cc @cockroachdb/release --- This validation is fine because the function itself is only upgrading the format. related to #26422 Release note: None Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #26784.
/cc @cockroachdb/release
This validation is fine because the function itself is only
upgrading the format.
related to #26422
Release note: None