Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: update comments on a test #33700

Conversation

andreimatei
Copy link
Contributor

Release note: None

@andreimatei andreimatei requested review from tbg and a team January 13, 2019 18:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andreimatei
Copy link
Contributor Author

r1 and r2 are #33381

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed r3 only. :lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andreimatei andreimatei force-pushed the random.improve-TestRaftRetryCantCommitIntents-comment branch from 6019992 to e1a4e1f Compare January 14, 2019 19:09
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

craig bot pushed a commit that referenced this pull request Jan 14, 2019
33700: storage: update comments on a test r=andreimatei a=andreimatei

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jan 14, 2019

Build succeeded

@craig craig bot merged commit e1a4e1f into cockroachdb:master Jan 14, 2019
@andreimatei andreimatei deleted the random.improve-TestRaftRetryCantCommitIntents-comment branch January 15, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants