Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Reject INTERVAL nanoseconds #35980

Merged
merged 1 commit into from
Mar 20, 2019
Merged

sql: Reject INTERVAL nanoseconds #35980

merged 1 commit into from
Mar 20, 2019

Conversation

bobvawter
Copy link
Member

This change is a follow-up to #32143 and #34202. This changes the parser to
reject the "nanoseconds" token when parsing an INTERVAL value.

Fixes: #35872

Release note: None

@bobvawter bobvawter requested review from maddyblue and a team March 20, 2019 12:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bobvawter bobvawter requested a review from a team as a code owner March 20, 2019 15:11
@bobvawter
sql: Reject INTERVAL nanoseconds
a1fdd00 
This change is a follow-up to #32143 and #34202.  This changes the parser to
reject the "nanoseconds" token when parsing an INTERVAL value.

Fixes: #35872

Release note: None
@bobvawter bobvawter requested a review from a team March 20, 2019 16:06
@bobvawter
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 20, 2019

Build failed

@bobvawter
Copy link
Member Author

bors r+

Looks like a test-rig flake.

craig bot pushed a commit that referenced this pull request Mar 20, 2019
@bobvawter
Merge #35980
0d885ef 
35980: sql: Reject INTERVAL nanoseconds r=bobvawter a=bobvawter

This change is a follow-up to #32143 and #34202.  This changes the parser to
reject the "nanoseconds" token when parsing an INTERVAL value.

Fixes: #35872

Release note: None

Co-authored-by: Bob Vawter <bob@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Mar 20, 2019

Build succeeded

@craig craig bot merged commit a1fdd00 into cockroachdb:master Mar 20, 2019
@bobvawter bobvawter deleted the fix-35872 branch March 20, 2019 20:49
@knz
Copy link
Contributor

knz commented Mar 22, 2019

does this want a backport?

@awoods187
Copy link
Contributor

Yes--it should be in 19.1

@bobvawter
Copy link
Member Author

This was backported to 19.1 in #36001

@knz
Copy link
Contributor

knz commented Mar 22, 2019

Thanks. Somehow backboard did not see it.

(You know about that tool backport that automates things, right? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddyblue maddyblue maddyblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobvawter @cockroach-teamcity @knz @awoods187 @maddyblue