parser: Add user defined column families to CTAS. #38904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Will be cleaner once #38589 is merged. |
adityamaru27
force-pushed
the
ctas-add-col-family
branch
from
07db8f2
to
f276653
Compare
Done. |
dt
approved these changes
Jul 17, 2019
pkg/sql/parser/sql.y
Outdated
| { | ||
| $$.val = tree.NamedColumnQualification{Qualification: &tree.ColumnFamilyConstraint{Create: true}} | ||
| } | ||
| | CREATE IF NOT EXISTS FAMILY family_name |
There was a problem hiding this comment.
I’m kinda surprised we need all these extra syntaxes — we’re creating a new table so create and in particular ifnotexists seem implied? I donno I don’t feel strongly about it
There was a problem hiding this comment.
@rolandcrosby do you have any inputs on this? This is w.r.t what column qualifiers we support when grouping into a FAMILY. I agree with David, I just copy-pasted from the qualifiers CREATE and ALTER support.
There was a problem hiding this comment.
yeah I would just support the "FAMILY" syntax in CTAS; don't think there's any reason to complicate things by adding redundant "create" or "if not exists" qualifiers for column families here.
adityamaru27
force-pushed
the
ctas-add-col-family
branch
from
f276653
to
dc5ca38
Compare
This change introduces grammar to support user defined column families. We are able to entirely piggyback on the existing CREATE TABLE logic handling this, and thus there are no changes outside of `pkg/parser`. Added logic tests to verify behavior. Release note (sql change): CREATE TABLE ... AS allows user defined column families.
adityamaru27
force-pushed
the
ctas-add-col-family
branch
from
dc5ca38
to
3e0f26d
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
38904: parser: Add user defined column families to CTAS. r=adityamaru27 a=adityamaru27 This change introduces grammar to support user defined column families in a CREATE TABLE ... AS query. 38913: deps: bump go.etcd.io/etcd r=tbg a=danhhz To pick up etcd-io/etcd#10864. Release note: None 38972: exec: fix calculation of selectivity stat when num batches is zero r=yuzefovich a=yuzefovich Release note: None Co-authored-by: Aditya Maru <adityamaru@cockroachlabs.com> Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com> Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
|
closes #38906 |
ericharmeling
added a commit
to cockroachdb/docs
that referenced
this pull request
Aug 21, 2019
Parameter updates Diagram updates Examples now use MovR Code PRs: cockroachdb/cockroach#38589 cockroachdb/cockroach#38904 Fixes #5190
ericharmeling
added a commit
to cockroachdb/docs
that referenced
this pull request
Aug 21, 2019
Parameter updates Diagram updates Examples now use MovR Code PRs: cockroachdb/cockroach#38589 cockroachdb/cockroach#38904 Fixes #5190
ericharmeling
added a commit
to cockroachdb/docs
that referenced
this pull request
Aug 26, 2019
Parameter updates Diagram updates Examples now use MovR Code PRs: cockroachdb/cockroach#38589 cockroachdb/cockroach#38904 Fixes #5190
ericharmeling
added a commit
to cockroachdb/docs
that referenced
this pull request
Aug 26, 2019
Parameter updates Diagram updates Examples now use MovR New primary key example for partitioning Code PRs: cockroachdb/cockroach#38589 cockroachdb/cockroach#38904 Fixes #5190
ericharmeling
added a commit
to cockroachdb/docs
that referenced
this pull request
Aug 28, 2019
Parameter updates Diagram updates Examples now use MovR New primary key example for partitioning Code PRs: cockroachdb/cockroach#38589 cockroachdb/cockroach#38904 Fixes #5190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces grammar to support user defined
column families in a CREATE TABLE ... AS query.