release-19.2: Revert "sql: Add support for timestamp objects with precision" #42286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 824ec01. Release note (bug fix): revert ability to create second-precision (0-precision) timestamp datatypes, which inadvertently caused a backward compatibility issue that automatically made previously-existing timestamp columns from 19.1 into second-precision columns.
|
This change is |
|
lgtm |
|
We originally added support for (6) for Flowable. I understand that will still work. Now (0) will not work (#16349). This will set back ORM compatibility. It's needed for Symfony4/Doctrine, Laravel, Ecto in Elixir, and potentially others. |
|
Good catch. I reopened #32098. You probably want to update the airtable entry accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #42285.
Fixes #42040
Fixes #42283.
/cc @cockroachdb/release
This reverts commit 824ec01.
Release note (bug fix): revert ability to create second-precision
(0-precision) timestamp datatypes, which inadvertently caused a backward
compatibility issue that automatically made previously-existing
timestamp columns from 19.1 into second-precision columns.