Commits on Feb 15, 2020

1. sql: separate metrics for restart and non-restart savepoints …

   Release note (sql change): CockroachDB now collects separate sets of
   metrics for usage of SAVEPOINT: one set for regular SQL savepoints and
   one set for uses dedicated to CockroachDB's client-side transaction
   retry protocol.

   

   knz committed Feb 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 7d76bdc
   • Browse repository at this point

   Copy the full SHA

   7d76bdc View commit details

   Browse the repository at this point in the history

2. sql: preliminary executor logic for savepoints …

   This commit introduces support for regular SQL savepoints in the
   executor.
   
   The following is supported:
   
   - recognizing the SAVEPOINT / ROLLBACK TO SAVEPOINT / RELEASE
     SAVEPOINT statements even when the savepoint name is not
     "cockroach_restart".
   - maintaining a list of current active savepoints, and detect
     when SAVEPOINT and RELEASE/ROLLBACK are mismatched.
   - issue the `GetSavepoint()` / `RollbackToSavepoint()` /
     `ReleaseSavepoint()` API calls to the KV layers.
   - enforce that `cockroarch_restart` (and retry savepoints in general)
     are not started "under" a regular savepoint.
   
   What is not supported yet:
   
   - Rejecting ROLLBACK after a DDL statement has executed.
   - ROLLBACK when the txn is aborted (i.e. after an error).
   
   Release note (sql change): CockroachDB now provides
   rudimentary (incomplete) and experimental support for SQL savepoints.
   
   Release note (sql change): CockroachDB supports a new statement `SHOW
   SAVEPOINT STATUS` which reveals the current stack of active
   savepoints. This can be used to teach savepoint usage.

   

   knz committed Feb 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 69533b3
   • Browse repository at this point

   Copy the full SHA

   69533b3 View commit details

   Browse the repository at this point in the history