-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: move the existing savepoint logic to a separate file #44684
Conversation
427948c
to
6902fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @knz)
pkg/sql/conn_executor_exec.go, line 568 at r1 (raw file):
// commitSQLTransaction executes a commit after the execution of a stmt, // which can be any statement when executing a statement with an implicit // transaction, or a COMMIT statement when using
[nit]: could combine these two short lines.
pkg/sql/conn_executor_savepoints.go, line 79 at r1 (raw file):
// execRollbackToSavepointInOpenState runs a ROLLBACK TO SAVEPOINT // statmeent inside an open txn.
s/statmeent/statement/g
.
This commit re-organizes the code without any functional change. Release note: None
6902fe1
to
afc823e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFYR!
bors r=yuzefovich
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @yuzefovich)
pkg/sql/conn_executor_exec.go, line 568 at r1 (raw file):
Previously, yuzefovich wrote…
[nit]: could combine these two short lines.
Done.
pkg/sql/conn_executor_savepoints.go, line 79 at r1 (raw file):
Previously, yuzefovich wrote…
s/statmeent/statement/g
.
Done.
43828: backupccl: add full cluster restore r=pbardea a=pbardea This commit adds the ability to entirely restore a full cluster backup. This includes replacing the contents of some system tables to match the data in the backup. Full cluster restore can be used using the `RESTORE FROM ...` syntax and is expected to be run on a new cluster with no user data. Release note (enterprise change): Add full cluster restore feature which restores all the information contained in a full cluster backup. This includes all of the user data as well as relevant data from system tables. It is expected to be run on a new cluster with no user data. 44684: sql: move the existing savepoint logic to a separate file r=yuzefovich a=knz This commit re-organizes the code without any functional change. (Split from #43051 for ease of review.) Co-authored-by: Paul Bardea <pbardea@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Build succeeded |
This commit re-organizes the code without any functional change.
(Split from #43051 for ease of review.)