sqlsmith: teach sqlsmith about savepoints #44695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohany
requested review from
knz and
yuzefovich
and removed request for
knz and
yuzefovich
|
This change is |
|
Just going to put this up here until #43051 is merged so we can actually test it out. |
|
thank you! that helps |
Fixes cockroachdb#44686. This PR teaches SQLSmith about savepoints, and sets it up to use only in situations where we don't have DDLs. Release note: None
rohany
force-pushed
the
sqlsmith-savepoints
branch
from
e54e281
to
7ad1910
Compare
yuzefovich
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
Let's have these nightlies run. bors r=yuzefovich |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44686.
This PR teaches SQLSmith about savepoints, and sets it
up to use only in situations where we don't have DDLs.
Release note: None