sql: more EXPLAIN improvements #53003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
Aug 19, 2020
This change removes some unnecessary fields, and relegates others to the VERBOSE variant. Release note (sql change): various improvements to EXPLAIN plans.
This change folds the type of join (inner/outer/etc) into the node name itself (e.g. `hash join (left outer)`). The "inner" type is omitted in non-verbose mode. Release note (sql change): various improvements to EXPLAIN plans.
Move "scalar" to the node name instead of a separate field. Release note (sql change): various improvements to EXPLAIN plans.
Improve the node names for set operation: `union/intersect/except [all]`. Release note (sql change): various improvements in EXPLAIN plans.
RaduBerinde
force-pushed
the
explain-improvements-2
branch
from
1f32454
to
266c711
Compare
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors r+ |
|
Build succeeded: |
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Aug 20, 2020
Reverts a portion of cockroachdb#53003. These attributes are not included when they are not interesting, but when they are included, they are very interesting and deserve to be surfaced.
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: omit various EXPLAIN fields in non-verbose mode
This change removes some unnecessary fields, and relegates others to the VERBOSE
variant.
Release note (sql change): various improvements to EXPLAIN plans.
sql: improve EXPLAIN output for join nodes
This change folds the type of join (inner/outer/etc) into the node name itself
(e.g.
hash join (left outer)). The "inner" type is omitted in non-verbosemode.
Release note (sql change): various improvements to EXPLAIN plans.
sql: improve EXPLAIN output for scalar group by
Move "scalar" to the node name instead of a separate field.
Release note (sql change): various improvements to EXPLAIN plans.
sql: improve EXPLAIN output for set operations
Improve the node names for set operation:
union/intersect/except [all].Release note (sql change): various improvements in EXPLAIN plans.