coldata,sql: remove some todos #53588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/col/coldata/batch.go, line 75 at r1 (raw file):
var _ Batch = &MemBatch{} // TODO(jordan): tune.
Add a comment about your benchmarks for future readers
This commit removes several TODOs that I have prototyped addressing and decided to abandon the prototypes, namely: - checking whether `coldata.BatchSize()` atomic has influence on performance (the benchmarks and TPCH queries showed that the impact is negligible if any) - tuning default batch size (I did that a while ago, and the best batch size according tpchvec/bench was 1280, barely better than current 1024 which is a lot nicer number) - pooling allocations of `execFactory` objects (this showed some improvement on one workload and a regression on another). Release justification: non-production code changes. Release note: None
yuzefovich
force-pushed
the
remove-todos
branch
from
ea6014b
to
34c79fc
Compare
yuzefovich
commented
Aug 31, 2020
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/col/coldata/batch.go, line 75 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Add a comment about your benchmarks for future readers
Done.
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes several TODOs that I have prototyped addressing and
decided to abandon the prototypes, namely:
coldata.BatchSize()atomic has influence onperformance (the benchmarks and TPCH queries showed that the impact is
negligible if any)
batch size according tpchvec/bench was 1280, barely better than current
1024 which is a lot nicer number)
execFactoryobjects (this showed someimprovement on one workload and a regression on another).
Release justification: non-production code changes.
Release note: None