telemetry: fix the integer quantization #53604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The code was previously quantizing 100 to 10, and only 101 and higher to 100. This patch fixes it. Additionally, this code ensures that negative values also get quantized. This change does not impact any caller for now (there is no caller that expects negative value) but will be used in an upcoming setting telemetry change. Release justification: low risk, high benefit changes to existing functionality Release note: None
knz
force-pushed
the
20200828-fix-setting-quantization
branch
from
1ac12a2
to
a677e80
Compare
irfansharif
approved these changes
Aug 31, 2020
|
thanks! bors r=irfansharif |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was previously quantizing 100 to 10, and only
101 and higher to 100. This patch fixes it.
Additionally, this code ensures that negative values also get
quantized. This change does not impact any caller for now (there is no
caller that expects negative value) but will be used in an upcoming
setting telemetry change.
Release justification: low risk, high benefit changes to existing functionality
Release note: None