stats: fix and unskip flaky test TestCreateStatsProgress #53681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)
pkg/sql/stats/create_stats_job_test.go, line 610 at r1 (raw file):
// Invalidate the stats cache so that we can be sure to get the latest stats. tableID := descpb.ID(53)
[nit] would be nice to get the table ID programatically (SELECT id FROM system.namespace WHERE name = 't')
Release justification: non-production code changes This commit fixes the flaky test TestCreateStatsProgress and unskips it. TestCreateStatsProgress was flaky because of the recent changes to the stats cache, which removed the guarantee that fresh stats would be available in the cache immediately after stats creation. This commit fixes the issue by explicitly invalidating the stats cache before the part of TestCreateStatsProgress that expects certain stats to be present. Fixes cockroachdb#52782 Release note: None
rytaft
commented
Aug 31, 2020
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/stats/create_stats_job_test.go, line 610 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] would be nice to get the table ID programatically (
SELECT id FROM system.namespace WHERE name = 't')
Done.
RaduBerinde
reviewed
Aug 31, 2020
|
bors r+ |
|
Build succeeded: |
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: non-production code changes
This commit fixes the flaky test
TestCreateStatsProgressand unskipsit.
TestCreateStatsProgresswas flaky because of the recent changes tothe stats cache, which removed the guarantee that fresh stats would be
available in the cache immediately after stats creation. This commit
fixes the issue by explicitly invalidating the stats cache before the
part of
TestCreateStatsProgressthat expects certain stats to be present.Fixes #52782
Release note: None