Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: extract k/v operations from insert/update/delete #6211

Merged
merged 1 commit into from
Apr 25, 2016
Merged

sql: extract k/v operations from insert/update/delete #6211

merged 1 commit into from
Apr 25, 2016

Commits on Apr 25, 2016

  1. sql: extract k/v operations from insert/update/delete 

    Separates the mapping between table rows/indexes and key/values for the
mutative operations. This will be useful immediately for implementing UPSERT and
eventually for TableWriter.

I tried to keep this as pure a refactor as I could, but it was a lot simpler to
model an UPDATE with a PK change as a delete followed by an update (instead of
migrating the mess I committed before).

I'm still not clear which component decides which columns are required, but I
think the additionally complexity that UPSERT/REPLACE adds will make it more
obvious one way or another. Once that happens it should be more obvious how to
handle all these colIDtoRowIndex maps.
    @danhhz
    danhhz committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    9115966 View commit details
    Browse the repository at this point in the history