logging: consolidate logging functions to always take a context #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 135 of 135 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Mechanical change to require a context on all logging functions. I will file issues against various components for auditing the call sites to replace context.TODO() with a real context. Part of cockroachdb#1779.
RaduBerinde
force-pushed
the
logging-ctx-squashed
branch
from
69d0b00
to
21271f3
Compare
This was referenced Jul 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly mechanical change to require a context on all logging functions.
I will file issues against various components for auditing the call sites to
replace
context.TODO()with a real context.Part of #1779.
@tschottdorf @petermattis The only thing to look at is
util/log/log.go.This change is