Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: builtins: implement to_char for timestamps and intervals #91541

Merged
merged 4 commits into from
Nov 8, 2022
Merged

release-22.2: builtins: implement to_char for timestamps and intervals #91541

merged 4 commits into from
Nov 8, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Nov 8, 2022

Backport 4/4 commits from #91382.

/cc @cockroachdb/release

Resolves #91156

These commits implement to_char for timestamp and interval types. Most
of the code is copied from the PG implementation.

Release justification: critical feature addition with minimal blast radius

@otan otan requested review from rafiss and a team November 8, 2022 19:44
@otan otan requested a review from a team as a code owner November 8, 2022 19:44
@blathers-crl
Copy link

blathers-crl bot commented Nov 8, 2022 •
edited by otan
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
builtins: implement to_char for timestamp types
af3db3d 
Release note (sql change): The `to_char(timestamp, string)` function
has now been implemented.
@otan
tree: move duration parsing logic to duration package
c939178 
To allow parsing intervals in more places, move the duration parsing
logic to the duration package.

Release note: None
@otan
builtins: implement to_char for intervals
c885d59 
Release note (sql change): The `to_char(interval, string)` builtin has
now been implemented.
@otan
tochar: implement roman numerals for to_char
2ae1bc3 
For ~shits and giggles~ completeness!

This commit implements the roman numeral commands for to_char.

Release note: None
@otan otan merged commit 60b6538 into cockroachdb:release-22.2 Nov 8, 2022
@otan otan deleted the backport22.2-91382 branch November 8, 2022 21:31
This was referenced Nov 8, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otan @cockroach-teamcity @rafiss