Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execbuilder: move explain test out of logictest #99396

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

msirek
Copy link
Contributor

@msirek msirek commented Mar 23, 2023

This moves the EXPLAIN test of #98373 from logictest to execbuilder.

Informs #98373

Release note: None

This moves the EXPLAIN test of cockroachdb#98373 from logictest to execbuilder.

Informs cockroachdb#98373

Release note: None
@msirek msirek requested a review from yuzefovich March 23, 2023 16:46
@msirek msirek requested a review from a team as a code owner March 23, 2023 16:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msirek)

Copy link
Contributor Author

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!
bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msirek)

@craig
Copy link
Contributor

craig bot commented Mar 23, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants