go.mod,.github: upgrade to Go 1.21 #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There's an effort underway to upgrade to Go 1.21 before shipping 23.2. Begin testing 1.21 in Pebble CI, and declare Go 1.21 in the go.mod file. Informs cockroachdb/cockroach#97260.
|
1.21.2 is available. Does this patch pin to Edit: ignore my lazyweb question. I looked at the CI run, and it looks like it's smart enough to pick up the latest. Admittedly, GH only has |
|
TFTR! |
|
Since resyncing my master, GoLand keeps making this change to my -go 1.20
+go 1.21
+
+toolchain go1.21.1My guess is that it has to do with this change - cockroach now depends on this library at a sha which is marked as requiring go 1.21. I expect many people will run into this. |
|
Opened #2987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an effort underway to upgrade to Go 1.21 before shipping 23.2. Begin testing 1.21 in Pebble CI, and declare Go 1.21 in the go.mod file.
Informs cockroachdb/cockroach#97260.