across schema query when sqlalchemy.Table autoload=True #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarnell
reviewed
Jul 12, 2017
cockroachdb/sqlalchemy/dialect.py
Outdated
| @@ -155,6 +157,10 @@ def get_pk_constraint(self, conn, table_name, schema=None, **kw): | |||
| res["name"] = pk["name"] | |||
| return res | |||
|
|
|||
| def get_foreign_keys(self, connection, table_name, schema=None, **kw): | |||
There was a problem hiding this comment.
Add a # TODO(bdarnell): comment here to implement foreign key introspection.
|
|
||
|
|
||
| class CockroachCompiler(PGCompiler_psycopg2): | ||
| def returning_clause(self, stmt, returning_cols): |
There was a problem hiding this comment.
Add a TODO comment to remove this when cockroachdb/cockroach#17008 is fixed.
xinbo
changed the title
xinbo
changed the title
bdarnell
approved these changes
Jul 14, 2017
cockroachdb/sqlalchemy/dialect.py
Outdated
| @@ -97,7 +99,9 @@ def has_table(self, conn, table, schema=None): | |||
| def get_columns(self, conn, table_name, schema=None, **kw): | |||
| res = [] | |||
| # TODO(bdarnell): escape table name | |||
| for row in conn.execute('SHOW COLUMNS FROM "%s"' % table_name): | |||
| # when table's schema not equal db uri default schema, need pass schema.table_name | |||
| # for row in conn.execute('SHOW COLUMNS FROM "%s"' % table_name): | |||
There was a problem hiding this comment.
Don't just comment out the old code, remove it completely. And I don't think we need the comment above.
Affects get_columns, get_indexes, and the RETURNING clause.
|
Thanks! I've rebased this to clean up the history now that #29 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in dialect:CockroachDBDialect
get_columns and get_indexes change
show * from table
to
show * from schema.table
add stmt_compiler:CockroachCompiler
change
insert into *** returning schema.table.pkey
to
insert into *** returning table.pkey