Add KDE depth unwrapping support #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Sure, done. |
|
Any update on merging this? I've been using Tobias's fork and it hasn't caused any problems for me. Thanks! |
|
Sorry, I just forgot to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a trivial PR to add support to the newly added KDE depth unwrapping introduced in libfreenect2: OpenKinect/libfreenect2@ff7ae0b
The only issue is that compilation will break if libfreenect2 isn't up-to-date. However, there is no versioning support so I don't see an easy way around this.
Best, Tobias