Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct image sequence on comparison #123

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Conversation

pgoellnitz
Copy link
Contributor

Context

The output setting ignoreAreasColoredWith must use the colored areas in the base image to correctly apply the ignored areas to the actual image.
#122

Cause

Base und actual image are inverted when comparing images.

Fix

Switch the order of the images. The parameter image1 must be the actualImage and image2 must be the baseImage.

@sharath2106 sharath2106 merged commit 0085e25 into codeceptjs:1.9.7 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants