Skip to content

Commit

Permalink
docs: add about impact on Model
Browse files Browse the repository at this point in the history
  • Loading branch information
kenjis committed Dec 9, 2023
1 parent 5cde3b7 commit 05645ce
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion user_guide_src/source/changelogs/v4.5.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@ limit(0) Behavior
generated SQL statement will have no ``LIMIT`` clause and all records will be
returned.
- It is recommended that ``$limitZeroAsAll`` in **app/Config/Feature.php** be set
to ``false`` as this incorrect behavior will be fixed in a future version.
to ``false`` as this incorrect behavior will be fixed in a future version. See
also :ref:`v450-model-findall-limit-0-behavior`.

Forge
-----
Expand All @@ -274,6 +275,17 @@ Others
Model
=====

.. _v450-model-findall-limit-0-behavior:

findAll(0) Behavior
-------------------

- Added a feature flag ``Feature::$limitZeroAsAll`` to fix the incorrect behavior
of ``limit(0)`` for Query Builder. See :ref:`v450-query-builder-limit-0-behavior`
for details.
- If you disable this flag, you need to change code like ``findAll(0, $offset)``
to ``findAll(null, $offset)``.

Libraries
=========

Expand Down

0 comments on commit 05645ce

Please sign in to comment.