feat: add HTTP method to web page cache key

codeigniter4 · Dec 25, 2023 · 0c01fbc · 0c01fbc
1 parent ec67f73
commit 0c01fbc
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/system/Cache/ResponseCache.php b/system/Cache/ResponseCache.php
@@ -86,7 +86,7 @@ public function generateCacheKey($request): string
             ? $uri->getQuery(is_array($this->cacheQueryString) ? ['only' => $this->cacheQueryString] : [])
             : '';
 
-        return md5((string) $uri->setFragment('')->setQuery($query));
+        return md5($request->getMethod() . ':' . $uri->setFragment('')->setQuery($query));
     }
 
     /**

diff --git a/tests/system/Cache/ResponseCacheTest.php b/tests/system/Cache/ResponseCacheTest.php
@@ -169,6 +169,26 @@ public function testCachePageIncomingRequestWithCacheQueryString()
         $this->assertNull($cachedResponse);
     }
 
+    public function testCachePageIncomingRequestWithHttpMethods()
+    {
+        $pageCache = $this->createResponseCache();
+
+        $request = $this->createIncomingRequest('foo/bar');
+
+        $response = new Response($this->appConfig);
+        $response->setBody('The response body.');
+
+        $return = $pageCache->make($request, $response);
+
+        $this->assertTrue($return);
+
+        // Check cache with a request with the same URI path and different HTTP method
+        $request        = $this->createIncomingRequest('foo/bar')->withMethod('POST');
+        $cachedResponse = $pageCache->get($request, new Response($this->appConfig));
+
+        $this->assertNull($cachedResponse);
+    }
+
     public function testCachePageCLIRequest()
     {
         $pageCache = $this->createResponseCache();