Merge pull request #8609 from kenjis/deprecate-BaseConfig-services

refactor: remove unnecessary BaseService::$services assignment
codeigniter4 · Mar 5, 2024 · 87db593 · 87db593
2 parents 15ad0a3 + 3c71913
commit 87db593
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/system/Config/BaseService.php b/system/Config/BaseService.php
@@ -167,6 +167,8 @@ class BaseService
      * A cache of other service classes we've found.
      *
      * @var array
+     *
+     * @deprecated 4.5.0 No longer used.
      */
     protected static $services = [];
 
@@ -335,7 +337,6 @@ protected static function buildServicesCache(): void
 
                     if ($classname !== Services::class) {
                         self::$serviceNames[] = $classname;
-                        static::$services[]   = new $classname();
                     }
                 }
             }

diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst
@@ -450,6 +450,8 @@ Deprecations
 
 - **CodeIgniter:** The ``determinePath()`` method has been deprecated. No longer
   used.
+- **Services:** The ``BaseService::$services`` property has been deprecated. No
+  longer used.
 - **Response:** The constructor parameter ``$config`` has been deprecated. No
   longer used.
 - **Filters:**