fix: breaking change for object that implements toRawArray()

codeigniter4 · Nov 28, 2023 · 9745bac · 9745bac
1 parent 02e5a33
commit 9745bac
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -1735,7 +1735,18 @@ protected function timeToString(array $properties): array
      */
     protected function objectToRawArray($object, bool $onlyChanged = true, bool $recursive = false): array
     {
-        if ($object instanceof Entity) {
+        /**
+         * @deprecated 4.4.4  Checking `toRawArray()` method is deprecated.
+         */
+        if (method_exists($object, 'toRawArray')) {
+            if (! $object instanceof Entity) {
+                @trigger_error(
+                    'In Model, to use your own class that implemented the "toRawArray()" method is deprecated.'
+                    . ' It will be changed so that "toRawArray()" is only executed if the object is an CodeIgniter\'s "Entity".',
+                    E_USER_DEPRECATED
+                );
+            }
+
             $properties = $object->toRawArray($onlyChanged, $recursive);
         } else {
             $mirror = new ReflectionClass($object);