Merge pull request #8614 from kenjis/fix-model-save-empty-id

fix: Model::shouldUpdate() logic
codeigniter4 · Mar 15, 2024 · a87fd14 · a87fd14
2 parents e55d478 + ee1eb7c
commit a87fd14
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -731,7 +731,7 @@ protected function shouldUpdate($row): bool
     {
         $id = $this->getIdValue($row);
 
-        return ! ($id === null || $id === []);
+        return ! ($id === null || $id === [] || $id === '');
     }
 
     /**

diff --git a/tests/system/Models/SaveModelTest.php b/tests/system/Models/SaveModelTest.php
@@ -42,6 +42,24 @@ public function testSaveNewRecordObject(): void
         $this->seeInDatabase('job', ['name' => 'Magician']);
     }
 
+    /**
+     * @see https://github.com/codeigniter4/CodeIgniter4/issues/8613
+     */
+    public function testSaveNewRecordArrayWithEmptyStringId(): void
+    {
+        $this->createModel(JobModel::class);
+
+        $data = [
+            'id'          => '',
+            'name'        => 'Magician',
+            'description' => 'Makes peoples things dissappear.',
+        ];
+
+        $this->model->save($data);
+
+        $this->seeInDatabase('job', ['name' => 'Magician']);
+    }
+
     public function testSaveNewRecordArray(): void
     {
         $this->createModel(JobModel::class);