fix!: change $limit default value from 0 to null

codeigniter4 · Nov 30, 2023 · d19bf0d · d19bf0d
1 parent 4348749
commit d19bf0d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -382,7 +382,7 @@ abstract protected function doFindColumn(string $columnName);
      *
      * @return array
      */
-    abstract protected function doFindAll(int $limit = 0, int $offset = 0);
+    abstract protected function doFindAll(?int $limit = null, int $offset = 0);
 
     /**
      * Returns the first row of the result set.
@@ -594,7 +594,7 @@ public function findColumn(string $columnName)
      *
      * @return array
      */
-    public function findAll(int $limit = 0, int $offset = 0)
+    public function findAll(?int $limit = null, int $offset = 0)
     {
         if ($this->tempAllowCallbacks) {
             // Call the before event and check for a return

diff --git a/system/Model.php b/system/Model.php
@@ -226,7 +226,7 @@ protected function doFindColumn(string $columnName)
      * @return array
      * @phpstan-return list<row_array|object>
      */
-    protected function doFindAll(int $limit = 0, int $offset = 0)
+    protected function doFindAll(?int $limit = null, int $offset = 0)
     {
         $builder = $this->builder();