Merge pull request #8870 from kenjis/fix-DataCaster-nullable

fix: [Model] casting may throw InvalidArgumentException: Invalid parameter: nullable
codeigniter4 · May 10, 2024 · e68553f · e68553f
2 parents fd0a3b6 + 79ad7f1
commit e68553f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system/DataCaster/DataCaster.php b/system/DataCaster/DataCaster.php
@@ -159,7 +159,7 @@ public function castAs(mixed $value, string $field, string $method = 'get'): mix
             $params = array_map('trim', explode(',', $matches[2]));
         }
 
-        if ($isNullable) {
+        if ($isNullable && ! $this->strict) {
             $params[] = 'nullable';
         }
 

diff --git a/tests/_support/Models/UserCastsTimestampModel.php b/tests/_support/Models/UserCastsTimestampModel.php
@@ -28,8 +28,8 @@ class UserCastsTimestampModel extends Model
         'id'         => 'int',
         'name'       => 'base64',
         'email'      => 'json-array',
-        'created_at' => 'datetime',
-        'updated_at' => 'datetime',
+        'created_at' => '?datetime',
+        'updated_at' => '?datetime',
     ];
     protected array $castHandlers = [
         'base64' => CastBase64::class,