Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename Entity::setAttributes() to avoid name collision #5763

Closed
wants to merge 1 commit into from
Closed

fix: rename Entity::setAttributes() to avoid name collision #5763

wants to merge 1 commit into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 3, 2022

Description
Fixes #5762

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Mar 3, 2022
@kenjis kenjis mentioned this pull request Mar 3, 2022
Closed
mostafakhudair
mostafakhudair reviewed Mar 3, 2022
View reviewed changes
system/Entity/Entity.php
public function setAttributes(array $data)
public function injectRawData(array $data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing public function is BC, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added beraking change label.

@kenjis kenjis force-pushed the fix-entity-column-attributes branch from e1b319c to e583b34 Compare March 4, 2022 00:52
@kenjis kenjis mentioned this pull request Mar 7, 2022
Closed
5 tasks
@kenjis kenjis marked this pull request as draft June 23, 2022 01:06
@MGatner
Copy link
Member

MGatner commented Sep 16, 2022 •
edited
Loading

@kenjis Is this still relevant after #5809?

@kenjis kenjis added next major version? Read this for a relevant v5 idea and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Sep 17, 2022
@kenjis
Copy link
Member Author

kenjis commented Sep 17, 2022

At least, this PR won't be merged into 4.x.
But I want to fix this bad design in the future.

@najdanovicivan
Copy link
Contributor

I like the injectRawData naming. It can be merged into 4.x if setAttributes is still kept as deprecated so that we can upgrade before the next major version.

@kenjis kenjis mentioned this pull request Feb 1, 2023
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Feb 1, 2023

I sent PR #7208

@kenjis kenjis closed this Feb 1, 2023
@kenjis kenjis deleted the fix-entity-column-attributes branch February 11, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafakhudair mostafakhudair mostafakhudair left review comments

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities next major version? Read this for a relevant v5 idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Entity can't handle column named attributes
4 participants
@kenjis @MGatner @najdanovicivan @mostafakhudair