Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: DB Error always throws Exception CI_DBUG #6183

Merged
merged 8 commits into from
Jun 27, 2022
Merged

config: DB Error always throws Exception CI_DBUG #6183

merged 8 commits into from
Jun 27, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 24, 2022 •
edited
Loading

Description
Follow-up #6140

  • use $DBDebug instead of CI_DEBUG
  • change the BaseConnection::$DBDebug default value to true
  • InvalidArgumentException in BaseBuilder::_whereIn() is never suppressed by config

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added database Issues or pull requests that affect the database layer 4.3 labels Jun 24, 2022
MGatner
MGatner requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the rest looks good. I'm open to discussion on the invalid arguments, but IMO those should always throw regardless.

system/Database/BaseBuilder.php Outdated Show resolved Hide resolved
@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label Jun 26, 2022
@kenjis kenjis force-pushed the db-error-always-throws-exception-CI_DEBUG branch from fd99f76 to fca552e Compare June 26, 2022 01:52
@kenjis
Copy link
Member Author

kenjis commented Jun 26, 2022

Added the documentation.

@kenjis kenjis requested a review from MGatner June 26, 2022 02:18
@kenjis kenjis force-pushed the db-error-always-throws-exception-CI_DEBUG branch from 43ea5a8 to eca175f Compare June 26, 2022 02:23
@kenjis kenjis merged commit dfb16d9 into codeigniter4:4.3 Jun 27, 2022
@kenjis kenjis deleted the db-error-always-throws-exception-CI_DEBUG branch June 27, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @samsonasik @MGatner @paulbalandan