Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autoload helpers #6397

Merged
merged 11 commits into from
Aug 22, 2022
Merged

feat: autoload helpers #6397

merged 11 commits into from
Aug 22, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 20, 2022 •
edited
Loading

Description

  • add functionality to autoload helpers

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Aug 20, 2022
MGatner
MGatner requested changes Aug 20, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive moves on the tests! I have a flow suggestion, and obviously docs, but the rest is looking good.

app/Config/Autoload.php Outdated Show resolved Hide resolved
system/Autoloader/Autoloader.php Outdated Show resolved Hide resolved
@kenjis kenjis force-pushed the feat-autoload-helpers branch 2 times, most recently from c9928b1 to f5a58e9 Compare August 21, 2022 01:14
@kenjis
Copy link
Member Author

kenjis commented Aug 21, 2022

Added the docs.

@kenjis kenjis requested a review from MGatner August 22, 2022 02:16
MGatner
MGatner approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit e035c1f into codeigniter4:4.3 Aug 22, 2022
@kenjis kenjis deleted the feat-autoload-helpers branch August 22, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner