Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove type="text/javascript" in <script> tag #6606

Merged
merged 2 commits into from
Oct 6, 2022
Merged

refactor: remove type="text/javascript" in <script> tag #6606

merged 2 commits into from
Oct 6, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 29, 2022 •
edited
Loading

Description
The type attribute is unnecessary for JavaScript resources.
See #6602 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.3 labels Sep 29, 2022
@kenjis kenjis mentioned this pull request Sep 29, 2022
Closed
@kenjis kenjis marked this pull request as draft September 29, 2022 10:13
MGatner
MGatner approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a world we live in!

@kenjis kenjis force-pushed the remove-script-type-javascript branch from 6fd01a7 to cf2cc66 Compare October 5, 2022 03:01
@kenjis kenjis marked this pull request as ready for review October 5, 2022 03:11
@kenjis
refactor: remove type="text/javascript" in <script> tag
8c87a41 
The type attribute is unnecessary for JavaScript resources.
@kenjis
docs: update user guide
d0e48fb
@kenjis kenjis force-pushed the remove-script-type-javascript branch from 491e2b5 to d0e48fb Compare October 6, 2022 02:35
@kenjis kenjis merged commit 286a8fb into codeigniter4:4.3 Oct 6, 2022
@kenjis kenjis deleted the remove-script-type-javascript branch October 6, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totoprayogo1916 totoprayogo1916 totoprayogo1916 approved these changes

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @totoprayogo1916 @datamweb @MGatner