Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing getProtocolVersion() in MessageInterface #6702

Merged
merged 3 commits into from
Oct 18, 2022
Merged

fix: add missing getProtocolVersion() in MessageInterface #6702

merged 3 commits into from
Oct 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 17, 2022 •
edited
Loading

Description

  • add missing getProtocolVersion()
    • PSR-7 has the method

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.3 labels Oct 17, 2022
kenjis and others added 3 commits October 17, 2022 17:43
@kenjis
fix: add missing getProtocolVersion()
60efa59
@kenjis @paulbalandan
docs: fix typo
76315b2 
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@kenjis
docs: add changelog
b228f11
@kenjis
Copy link
Member Author

kenjis commented Oct 17, 2022

Added changelog.

@kenjis kenjis merged commit 6309010 into codeigniter4:4.3 Oct 18, 2022
@kenjis kenjis deleted the fix-MessageInterface branch October 18, 2022 00:11
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan