Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template types to Connection #6709

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add template types to Connection #6709

merged 1 commit into from
Oct 21, 2022

Conversation

paulbalandan
Copy link
Member

Description
Making BaseConnection a generic type, thus extensions need to specify the type of the connection.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Oct 18, 2022
MGatner
MGatner reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did those abstract functions go?

system/Database/BaseConnection.php Outdated Show resolved Hide resolved
@paulbalandan
Copy link
Member Author

paulbalandan commented Oct 18, 2022 •
edited
Loading

Where did those abstract functions go?

They are actually defined by ConnectionInterface and unnecessarily duplicated as abstract public in BaseConnection.

--
Edit: Extracted to #6713

@paulbalandan paulbalandan added the stale Pull requests with conflicts label Oct 19, 2022
@paulbalandan
Copy link
Member Author

I'll fix the conflicts once #6713 is merged.

@MGatner
Copy link
Member

MGatner commented Oct 19, 2022

Thanks for explaining (and extracting).

@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Oct 20, 2022
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 20, 2022
MGatner
MGatner approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup of the baseline!

@paulbalandan paulbalandan merged commit 4c3b162 into codeigniter4:4.3 Oct 21, 2022
@paulbalandan paulbalandan deleted the connection-template-types branch October 21, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @MGatner @kenjis