Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing ResultInterface::getNumRows() #6778

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: add missing ResultInterface::getNumRows() #6778

merged 1 commit into from
Oct 28, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 28, 2022 •
edited
Loading

Description
Fixes #6776
See #4356

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.3 labels Oct 28, 2022
@kenjis kenjis mentioned this pull request Oct 28, 2022
Closed
@kenjis kenjis merged commit 1abb1f4 into codeigniter4:4.3 Oct 28, 2022
@kenjis kenjis deleted the add-ResultInterface-getNumRows branch October 28, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan