Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove CI_DEBUG check in Model #6863

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: remove CI_DEBUG check in Model #6863

merged 1 commit into from
Nov 15, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 15, 2022

Description
It is not good if the behavior changes only in the production environment.
It is impossible to write tests for the production environment (CI_DEBUG is false).

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: remove CI_DEBUG check in Model
fabb284 
To avoid changes in behavior between development and production environments.
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.3 labels Nov 15, 2022
MGatner
MGatner approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very much agree.

@kenjis kenjis merged commit 8469879 into codeigniter4:4.3 Nov 15, 2022
@kenjis kenjis deleted the remove-CI_DEBUG-in-Model branch November 15, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner