Add is_windows() global function

[paulbalandan]

Description

• Adds is_windows() global function, for uniform detection of Windows platform
• Deprecate CLI::isWindows(), as platform detection is not limited to console
• Normalize platform detection

Related: #6882

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[MGatner]

I read conflicting options on whether uname() or if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') is better. If you feel confident this is the way then I trust you.

We should find a way to make this mockable so people can test their Windows-specific code without being on Windows. My initial thought is to add a parameter to set/clear a local static value:

public function testWindowsUsesBananas() {
    is_windows(true);

    $this->assertSame('bananas', $this->execute('getFruitByOs');

    is_windows(null);
}

It's a little bit hacky but thus is functional programming 🤷‍♂️ Only other alternative might be to stick the value on CodeIgniter along with $context.

[paulbalandan]

On WSL, PHP_OS is Linux so the check would fail on that. DIRECTORY_SEPARATOR is also "/" on WSL.

[kenjis]

De we really need to detect WSL as Windows?

It seems WSL supports Chmod/Chown.
https://devblogs.microsoft.com/commandline/chmod-chown-wsl-improvements/

[paulbalandan]

It seems WSL supports Chmod/Chown. https://devblogs.microsoft.com/commandline/chmod-chown-wsl-improvements/

It seems the article is referring to the native filesystem functions, not the PHP equivalents. As tested in WSL, PHP's chmod behaves as if running on native Windows.

[kenjis]

Do you mount your drive with -o metadata?
See microsoft/WSL#3172

In my understanding, PHP's chmod() is kind of wrapper for the native filesystem functions.

[paulbalandan]

Thanks for the link!

I was not able to make it work on the first try. I first need to uninstall all php related from WSL, then proceeding with unmounting and remounting:

sudo apt remove -y php8.2-*
cd /
sudo umount /mnt/c
sudo mount -t drvfs C: /mnt/c -o metadata,uid=1000,gid=1000

Now, chmod works on WSL:

$ vendor/bin/phpunit --filter GeneratorsTest --no-coverage
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.0RC5
Configuration: /mnt/c/Users/P/Desktop/Web Dev/CodeIgniter4/phpunit.xml.dist

........                                                                                                                              8 / 8 (100%)

Nexus\PHPUnit\Extension\Tachycardia identified these 4 slow tests:
⚠  Took 5.50s from 0.50s limit to run CodeIgniter\\Commands\\GeneratorsTest::testGenerateFileCreated
⚠  Took 1.52s from 0.50s limit to run CodeIgniter\\Commands\\GeneratorsTest::testSuffixingHasNoEffect
⚠  Took 1.36s from 0.50s limit to run CodeIgniter\\AutoReview\\FrameworkCodeTest::testEachTestClassHasCorrectGroupAnnotation with data set \"CodeIgniter\\Commands\\GeneratorsTest\"
⚠  Took 0.54s from 0.50s limit to run CodeIgniter\\Commands\\GeneratorsTest::testGenerateFileFailsOnUnwritableDirectory


Time: 00:10.806, Memory: 44.00 MB

OK (8 tests, 14 assertions)

[paulbalandan]

I'll update the PR to limit the function on native Windows.

[kenjis]

Please update the docs. Otherwise looks good.

[MGatner]

Thanks @paulbalandan! Looks good.

[juanma386]

Thank you very much for the improvements, from Argentina