Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add IncomingRequest::getRawInputVar() method #6943

Merged
merged 3 commits into from
Dec 11, 2022
Merged

feat: add IncomingRequest::getRawInputVar() method #6943

merged 3 commits into from
Dec 11, 2022

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Dec 5, 2022

Description
Working with raw input data should be as easy as in other cases. getRawInputVar() adds missing features that are available for other methods, like retrieving specified indexes and filtering data.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added enhancement PRs that improve existing functionalities 4.3 labels Dec 5, 2022
@kenjis
Copy link
Member

kenjis commented Dec 6, 2022 •
edited
Loading

I have a question: #6910 (comment)

@MGatner
Copy link
Member

MGatner commented Dec 10, 2022

Kenjis hit this hard. Ping me if you need another review.

@kenjis kenjis merged commit ddf1af1 into codeigniter4:4.3 Dec 11, 2022
@michalsn michalsn deleted the feature/getRawInputVar branch December 12, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @kenjis @MGatner