Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add application/vnd.microsoft.portable-executable and application/x-dosexec #7144

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

totoprayogo1916
Copy link
Contributor

Description
When using File Libraries,
$file->getMimeType(); returns null in files with extension .exe

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the enhancement PRs that improve existing functionalities label Jan 20, 2023
@paulbalandan
Copy link
Member

https://www.iana.org/assignments/media-types/application/vnd.microsoft.portable-executable

The first MIME type is IANA recognized. However, the second one I cannot find. Is it acceptable?

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with both. MIMEs are for developers, someone could always change it in their project.

@samsonasik samsonasik merged commit 5e25ac7 into codeigniter4:develop Jan 21, 2023
@samsonasik
Copy link
Member

Thank you @totoprayogo1916

@totoprayogo1916 totoprayogo1916 deleted the patch-1 branch January 22, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants