fix: [QueryBuilder] getOperatorFromWhereKey() misses EXISTS, BETWEEN

[kenjis]

Description
Follow-up #6986
Ref #7151, #7117

• fix BaseBuilder::getOperatorFromWhereKey() misses EXISTS or BETWEEN

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

With this PR, the following test passes:

$builder = $this->db->table('jobs');

$where = "created_on BETWEEN '2022-07-01' AND '2022-12-31'";
$builder->where($where, '', false); // empty string

$expectedSQL = "SELECT * FROM \"jobs\" WHERE created_on BETWEEN '2022-07-01' AND '2022-12-31' ";
$this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledSelect()));

$expectedBinds = [
    "created_on BETWEEN '2022-07-01' AND '2022-12-31'" => [
        0 => '',
        1 => false,
    ],
];
$this->assertSame($expectedBinds, $builder->getBinds());

But I still think this is a misuse, because the binding is completely wrong, and the output SQL has an extra space in the end.

[MGatner]

@codeigniter4/database-team please take a look. @kenjis Let me know if I need to do this one.

[sclubricants]

I don't think we should support BETWEEN, EXISTS, IS NULL, IS NOT NULL, IS TRUE, IS FALSE, etc. I'm not sure that these work the same across DBMS.

If your using these you should just do it with RawSql or with escape.

Another example:

SELECT 'something' AS test
WHERE IF(RAND()>=0.5,TRUE,FALSE)

This WHERE statement is great for randomly selecting rows or used with a weighted column.

[kenjis]

I don't think we should support BETWEEN, EXISTS, IS NULL, IS NOT NULL, IS TRUE, IS FALSE, etc. I'm not sure that these work the same across DBMS.

IS NULL, IS NOT NULL are supported already.

If we will support BETWEEN, EXISTS, the difference is only to add = after the key value or not.

[kenjis]

Another example:

What do you mean?
The following test passes in both before and after this PR:

        $builder = $this->db->table('jobs');

        $where = "IF(RAND()>=0.5,TRUE,FALSE)";
        $builder->where($where, null, false);

        $expectedSQL   = 'SELECT * FROM "jobs" WHERE IF(RAND()>=0.5,TRUE,FALSE)';
        $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledSelect()));

        $expectedBinds = [];
        $this->assertSame($expectedBinds, $builder->getBinds());

[sclubricants]

Yes this is correct:

        $where = "IF(RAND()>=0.5,TRUE,FALSE)";
        $builder->where($where, null, false);

I was trying to say we shouldn't support things like:

        $builder->where('column', 'IS NULL');

[kenjis]

The following is not supported before or after this PR:

$builder->where('column', 'IS NULL');
// 'SELECT * FROM "users" WHERE "column" = 'IS NULL''

The following is also not supported.

$builder->where('column', 'IS NULL', false);
// 'SELECT * FROM "users" WHERE column = IS NULL'

[kenjis]

@codeigniter4/database-team Can someone review?

[michalsn]

I'm not a fan of allowing:

$builder->where($where, '', false);

But since developers were using it this way, we shouldn't break their code.

[sclubricants]

I'm not sure why we need all of these spelled out.

There are a lot more of these.

SOUNDS LIKE
RLIKE
NOT RLIKE
IS TRUE
IS FALSE
FIND_IN_SET

[kenjis]

Probably no user used these, or did not send a bug report.

In my opinion it is not a good practice to write SQL strings in the key of where().
If a user wants to write SQL strings, it is better to use RawSql.
So I don't think it is necessary to add anything other than what are currently defined.

[kenjis]

@tangix With this PR, your issue #7117 will be fixed in v4.3.2.
See #7155 (comment)