fix: Throttler token time calculation #7160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In one of my applications where I use
Throttler
I detected thegetTokenTime()
is already at the minimum of 1 seconds even if the token refresh rate is far from reached:Example: 1 capacity, 3600 seconds -> After 10 minutes I expected 50 minutes to be left, but I was already at "1 second". Waiting another minute and executing the check, I was still at "1 second left".
This made me clear that the calculation for
Throttler::getTokenTime()
is still off, but the token value is calculated correctly after all, returnfalse
if$token < 1
. This PR should fix that.Checklist: