Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing composer.json in Mandatory File Changes #7170

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 23, 2023

Description

  • If a user installed CI4 manually, and installed a Composer package,
    Composer package Kint 4.x is installed and used.
    And it is not compatible with the updated Config file for Kint 5.x.
  • ComposerScripts::postUpdate will remove Kint files in system/ThirdParty/
    if we remove "kint-php/kint" in composer.json and run composer update.

Screenshot 2023-01-30 9 16 39

See codeigniter4/framework@f83c211#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only 4.3 labels Jan 23, 2023
@kenjis
Copy link
Member Author

kenjis commented Jan 30, 2023

Removing "kint-php/kint" is not enough.
Because after removing it if we run composer update,
"post-update-cmd" will remove Kint in system/ThirdParty/.

--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,6 @@
         "ext-intl": "*",
         "ext-json": "*",
         "ext-mbstring": "*",
-        "kint-php/kint": "^4.2",
         "laminas/laminas-escaper": "^2.9",
         "psr/log": "^1.1"
     },
@@ -51,9 +50,6 @@
         ]
     },
     "scripts": {
-        "post-update-cmd": [
-            "CodeIgniter\\ComposerScripts::postUpdate"
-        ],
         "test": "phpunit"
     },
     "support": {

It removes system/ThirdParty/Kint/* when running `composer update`
after removing `kint-php/kint` in composer.json.
@kenjis kenjis force-pushed the fix-docs-upgrade_430-composer.json branch from f4e66f9 to 2285ee7 Compare January 30, 2023 00:15
@kenjis kenjis merged commit 225eaae into codeigniter4:develop Feb 1, 2023
@kenjis kenjis deleted the fix-docs-upgrade_430-composer.json branch February 1, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.3 bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants