-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: site_url() does not use alt Config #7215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the custom config is fine. However, I'm not a fan of other parts that were refactored.
f9f0a8c
to
e39da9a
Compare
_get_uri() is no longer used.
… is true and fix errors if running on CLI.
31f5a42
to
e0a36ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only given this a first read. If you and @michalsn feel confident about it feel free to proceed, otherwise I will come back for a more thorough review. Framework URI handling is a sticky business.
In the end, the code was not that different from the original code. |
Description
Supersedes #7211
I need to refactor the three function code because I cannot fix without adding an parameter.
site_url()
does not use alt Configbase_url()
,site_url()
,current_url()
_get_uri()
Checklist: