Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Cookie config items in Config\App #7221

Merged
merged 9 commits into from
Feb 7, 2023
Merged

refactor: remove Cookie config items in Config\App #7221

merged 9 commits into from
Feb 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 4, 2023 •
edited
Loading

Description
Supersedes #7011

This PR is needed to fix Session Config issue: #4297 (comment) → #7255

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.4 refactor Pull requests that refactor code labels Feb 4, 2023
@kenjis kenjis force-pushed the remove-config-app-cookie-4.4 branch from 8c33b5d to 01f7a6b Compare February 5, 2023 04:32
michalsn
michalsn approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know, I'm not a fan of removing things like this in a minor version, but since others think differently and there is an agreement about it (I as understand) then I only checked the code and it seems ok 👍

MGatner
MGatner approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually glad to see this one happen. Hopefully not too many repercussions for devs.

@kenjis kenjis merged commit f8ae5a1 into codeigniter4:4.4 Feb 7, 2023
@kenjis kenjis deleted the remove-config-app-cookie-4.4 branch February 7, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.4 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner