Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [QueryBuilder] RawSql causes error when using like() and countAllResults() #7277

Merged
merged 2 commits into from
Feb 23, 2023
Merged

fix: [QueryBuilder] RawSql causes error when using like() and countAllResults() #7277

merged 2 commits into from
Feb 23, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 19, 2023

Description
Fixes #7268

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 19, 2023
@kenjis kenjis mentioned this pull request Feb 19, 2023
Closed
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Feb 20, 2023
@kenjis
Copy link
Member Author

kenjis commented Feb 20, 2023

@codeigniter4/database-team Please review.

@kenjis kenjis merged commit 2810595 into codeigniter4:develop Feb 23, 2023
@kenjis kenjis deleted the fix-QB-like-RawSql-countAllResults branch February 23, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: RawSql() triggers an error when used in combination with like() and countAllResults()
3 participants
@kenjis @michalsn @samsonasik