Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SQLSRV] getFieldData() supports nullable #7301

Merged
merged 2 commits into from
Mar 4, 2023
Merged

feat: [SQLSRV] getFieldData() supports nullable #7301

merged 2 commits into from
Mar 4, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 24, 2023 •
edited
Loading

Description

  • getFieldData() supports nullable

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.4 database Issues or pull requests that affect the database layer labels Feb 24, 2023
@kenjis kenjis force-pushed the feat-SQLSRV-getFieldData-nullable branch from 0043397 to 33c8e49 Compare February 24, 2023 06:58
@kenjis kenjis mentioned this pull request Feb 24, 2023
Merged
5 tasks
@kenjis kenjis force-pushed the feat-SQLSRV-getFieldData-nullable branch from f3d5fe4 to 287548f Compare February 24, 2023 08:34
@kenjis kenjis force-pushed the feat-SQLSRV-getFieldData-nullable branch from 287548f to a98658b Compare February 25, 2023 03:28
@kenjis
Copy link
Member Author

kenjis commented Mar 1, 2023

@codeigniter4/database-team Please review.

@kenjis kenjis mentioned this pull request Mar 1, 2023
Merged
5 tasks
@kenjis kenjis merged commit 82079cb into codeigniter4:4.4 Mar 4, 2023
@kenjis kenjis deleted the feat-SQLSRV-getFieldData-nullable branch March 4, 2023 00:40
@kenjis
Copy link
Member Author

kenjis commented Mar 4, 2023

@michalsn Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.4 database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn