-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Fix output buffering #7500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error installing Imagic. Tests are not available. |
kenjis
added
4.4
bug
Verified issues on the current code behavior or pull requests that will fix them
labels
May 15, 2023
michalsn
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a really good find and improvement. Thanks!
I have tested it a bit and see no issues.
Closed
kenjis
reviewed
May 18, 2023
kenjis
approved these changes
May 23, 2023
@iRedds Thank you. This made CodeIgniter.php code cleaner. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7493
Work with output buffering was carried out incorrectly.
To bypass an existing bug in tests, a hack was used
CodeIgniter4/tests/system/CodeIgniterTest.php
Lines 57 to 59 in 3b3cfb5
In my opinion, this PR correctly completes output buffering, including for exceptions.
Checklist: